Skip to content

Fix typos found in the codebase#3937

Merged
Madoshakalaka merged 6 commits intoyewstack:masterfrom
linkmauve:fix-typos
Mar 2, 2026
Merged

Fix typos found in the codebase#3937
Madoshakalaka merged 6 commits intoyewstack:masterfrom
linkmauve:fix-typos

Conversation

@linkmauve
Copy link
Copy Markdown
Contributor

@linkmauve linkmauve commented Oct 30, 2025 •
edited
Loading

Description

This fixes a bunch of typos found by the typos tool.

Would it make sense to add it to the CI in a future PR, to prevent further typos from being added?

Checklist

  • I have reviewed my own code
  • I have added tests (not relevant, plus tests don’t pass currently on master as of 71e24b7)

Edit: they do pass, but only with --features=ssr, otherwise yew::LocalServerRenderer isn’t present and packages/yew/tests/raw_html.rs:51 tries to use it anyway.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 30, 2025 •
edited
Loading

Benchmark - core

Yew Master

vnode           fastest       │ slowest       │ median        │ mean          │ samples │ iters
╰─ vnode_clone  2.403 ns      │ 3.792 ns      │ 2.407 ns      │ 2.462 ns      │ 100     │ 1000000000

Pull Request

vnode           fastest       │ slowest       │ median        │ mean          │ samples │ iters
╰─ vnode_clone  3.705 ns      │ 4.073 ns      │ 3.71 ns       │ 3.716 ns      │ 100     │ 1000000000

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 30, 2025 •
edited
Loading

Visit the preview URL for this PR (updated for commit 0777723):

https://yew-rs--pr3937-fix-typos-ygb3nqby.web.app

(expires Mon, 09 Mar 2026 06:59:58 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 30, 2025 •
edited
Loading

Benchmark - SSR

Yew Master

Details
Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 310.712 311.228 310.945 0.181
Hello World 10 475.444 488.570 481.040 5.140
Function Router 10 31137.096 32066.808 31744.484 266.666
Concurrent Task 10 1006.427 1007.735 1007.188 0.468
Many Providers 10 1080.719 1138.974 1109.351 18.498

Pull Request

Details
Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 310.804 315.059 311.475 1.281
Hello World 10 479.158 482.645 480.990 1.036
Function Router 10 31518.826 31947.746 31664.392 117.188
Concurrent Task 10 1005.950 1007.673 1007.084 0.587
Many Providers 10 1084.331 1141.470 1107.306 15.509

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 30, 2025 •
edited
Loading

Size Comparison

Details
examples master (KB) pull request (KB) diff (KB) diff (%)
async_clock 100.188 100.188 0 0.000%
boids 168.073 168.073 0 0.000%
communication_child_to_parent 93.464 93.464 0 0.000%
communication_grandchild_with_grandparent 105.240 105.240 0 0.000%
communication_grandparent_to_grandchild 101.603 101.603 0 0.000%
communication_parent_to_child 90.892 90.892 0 0.000%
contexts 105.142 105.142 0 0.000%
counter 86.274 86.274 0 0.000%
counter_functional 88.269 88.269 0 0.000%
dyn_create_destroy_apps 90.312 90.312 0 0.000%
file_upload 99.335 99.335 0 0.000%
function_delayed_input 94.362 94.362 0 0.000%
function_memory_game 172.937 172.937 0 0.000%
function_router 406.649 406.649 0 0.000%
function_todomvc 164.156 164.156 0 0.000%
futures 235.151 235.151 0 0.000%
game_of_life 104.709 104.709 0 0.000%
immutable 255.739 255.739 0 0.000%
inner_html 80.795 80.795 0 0.000%
js_callback 109.369 109.369 0 0.000%
keyed_list 179.717 179.717 0 0.000%
mount_point 84.139 84.139 0 0.000%
nested_list 113.048 113.048 0 0.000%
node_refs 91.518 91.518 0 0.000%
password_strength 1729.144 1729.144 0 0.000%
portals 93.027 93.027 0 0.000%
router 377.198 377.198 0 0.000%
suspense 113.450 113.450 0 0.000%
timer 88.625 88.625 0 0.000%
timer_functional 98.867 98.867 0 0.000%
todomvc 142.080 142.080 0 0.000%
two_apps 86.139 86.139 0 0.000%
web_worker_fib 136.215 136.215 0 0.000%
web_worker_prime 187.452 187.452 0 0.000%
webgl 83.217 83.217 0 0.000%

✅ None of the examples has changed their size significantly.

WorldSEnder
WorldSEnder previously approved these changes Nov 1, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@WorldSEnder WorldSEnder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, catches a nice number of typos.
Note that we have some spell checking in ci for markdown documents as a stopgap which relies on a custom dictionary.

Did you run into any false positives and if so, is there a way to disable that for (brand) names and similar?

@linkmauve
Fix typos found in the codebase
6d31e7d 
Thanks typos[1]!

[1] https://github.com/crate-ci/typos
@linkmauve
Add a typos.toml
54a6350 
It makes typos ignore two syllabes files, and one non-typo in a file.
@linkmauve
Replace aspell check with typos
d084850 
This works on all files instead of just the Markdown files, and already
found many issues aspell missed.
@linkmauve
Copy link
Copy Markdown
Contributor Author

linkmauve commented Nov 17, 2025

Looks good, catches a nice number of typos. Note that we have some spell checking in ci for markdown documents as a stopgap which relies on a custom dictionary.

I’ve now replaced this CI pass with a typos pass, to catch issues in all files instead of just Markdown ones, and removed the aspell shell script.

Did you run into any false positives and if so, is there a way to disable that for (brand) names and similar?

Only "Noo" and "ba", I’ve replaced the first one with "Nooo" to accentuate the effect, and ignored the second. The other false positives are from the syllables.txt files in examples, I’ve ignored the files themselves.

@Madoshakalaka
Merge branch 'master' into fix-typos
b2f3758
@Madoshakalaka
fix: rename typos.toml to _typos.toml, use child_name, bump typos action
41abade 
- Rename typos.toml to _typos.toml (recommended convention)
- Revert childs_name -> children_name; use child_name instead
  (original was possessive "child's", not plural)
- Bump crate-ci/typos action from v1.39.2 to v1.44.0
- Fix new typo in CHANGELOG.md from master merge
@Madoshakalaka
docs: add typos spell checking section to CONTRIBUTING.md
0777723
@Madoshakalaka
Copy link
Copy Markdown
Member

Madoshakalaka commented Mar 2, 2026

Thanks! Very valid PR. Pushing directly cuz it has been a while.

Changes I made on top:

  • Renamed typos.toml to _typos.toml (the recommended convention per typos docs)
  • Changed childs_name to child_name instead of children_name, false positive
  • Bumped crate-ci/typos action from v1.39.2 to v1.44.0
  • Fixed one new typo (erros -> errors) in CHANGELOG.md that came in from master since this PR was opened
  • Merged from master

@Madoshakalaka Madoshakalaka added A-ci Area: The continuous integration A-tools Area: Tools such as trunk, wasm-bindgen documentation labels Mar 2, 2026
Madoshakalaka
Madoshakalaka approved these changes Mar 2, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@Madoshakalaka Madoshakalaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All CI checks pass. LGTM.

@Madoshakalaka Madoshakalaka merged commit 8840e1f into yewstack:master Mar 2, 2026
40 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Madoshakalaka Madoshakalaka Madoshakalaka approved these changes

@WorldSEnder WorldSEnder WorldSEnder left review comments

Assignees

No one assigned

Labels

A-ci Area: The continuous integration A-tools Area: Tools such as trunk, wasm-bindgen documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@linkmauve @Madoshakalaka @WorldSEnder